Problem

The Map Refresh Service in content/wardrive.js is calling haversineDistance() which doesn't exist, causing this error:

Uncaught ReferenceError: haversineDistance is not defined
    at checkAndRefreshMap (wardrive.js:882:22)
    at onGpsPositionUpdateForMap (wardrive.js:909:3)

However, the codebase already has a calculateHaversineDistance() function defined at line 784-819 in content/wardrive.js on the dev branch that does exactly what we need.

Current Code (Broken)

In checkAndRefreshMap() function around line 882:

const distance = haversineDistance(  // ❌ This function doesn't exist
  mapRefreshService.lastRefreshLocation.lat,
  mapRefreshService.lastRefreshLocation.lon,
  lat,
  lon
);

Existing Function (Available)

The codebase already has this function at line 784:

function calculateHaversineDistance(lat1, lon1, lat2, lon2) {
  debugLog(`[GEOFENCE] Calculating Haversine distance: (${lat1.toFixed(5)}, ${lon1.toFixed(5)}) to (${lat2.toFixed(5)}, ${lon2.toFixed(5)})`);
  
  const R = 6371000; // Earth's radius in meters
  const toRad = (deg) => (deg * Math.PI) / 180;
  
  const dLat = toRad(lat2 - lat1);
  const dLon = toRad(lon2 - lon1);
  
  const a = 
    Math.sin(dLat / 2) * Math.sin(dLat / 2) +
    Math.cos(toRad(lat1)) * Math.cos(toRad(lat2)) *
    Math.sin(dLon / 2) * Math.sin(dLon / 2);
  
  const c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1 - a));
  const distance = R * c;
  
  debugLog(`[GEOFENCE] Haversine distance calculated: ${distance.toFixed(2)}m`);
  return distance;
}

This function is used by:

• validateGeofence() - geofence validation
• validateMinimumDistance() - 25m ping distance validation

Fix Required

Update the checkAndRefreshMap() function to call calculateHaversineDistance() instead of haversineDistance():

const distance = calculateHaversineDistance(  // ✅ Use existing function
  mapRefreshService.lastRefreshLocation.lat,
  mapRefreshService.lastRefreshLocation.lon,
  lat,
  lon
);

Files to Modify

• content/wardrive.js - Update checkAndRefreshMap() function to use calculateHaversineDistance()

Testing

After this fix:

1. Map should refresh every 5 seconds when connected
2. Map should refresh when GPS moves 25m from last refresh location
3. No more haversineDistance is not defined errors in console
4. Debug logs should show [GEOFENCE] tags from the distance calculation